SNMP V3 Added

[tiebingzhang]

Hi,

I have added some basic SNMP V3 support to your WapSNMP project. The V3 is implemented along with V1 and V2C. Right now only GetNext is implemented, but the rest can be implemented in a similar way. Would you like to pull and merge this into your repository?

Best regards,

Tiebing

[cdevr]

Nice I'll take a look at it tomorrow. I'm currently travelling.

Thanks !

On Wed, Nov 13, 2013 at 10:27 PM, tiebingzhang [email protected]:

Hi,

I have added some basic SNMP V3 support to your WapSNMP project. The V3 is implemented along with V1 and V2C. Right now only GetNext is implemented, but the rest can be implemented in a similar way. Would you like to pull and merge this into your repository?

Best regards,

Tiebing

You can merge this Pull Request by running

git pull https://github.com/tiebingzhang/WapSNMP master

Or view, comment on, or merge it at:

https://github.com/cdevr/WapSNMP/pull/1 Commit Summary

• V3 GetNext working
• removed debug messages
• updated README
• aes/des md5/sha1 all working now
• added the simple test file under utils

File Changes

• M README.md https://github.com/cdevr/WapSNMP/pull/1/files#diff-0(2)
• M ber.go https://github.com/cdevr/WapSNMP/pull/1/files#diff-1(33)
• M example.go https://github.com/cdevr/WapSNMP/pull/1/files#diff-2(52)
• M snmp.go https://github.com/cdevr/WapSNMP/pull/1/files#diff-3(394)
• M utils/getTable.gohttps://github.com/cdevr/WapSNMP/pull/1/files#diff-4(9)
• A utils/test.gohttps://github.com/cdevr/WapSNMP/pull/1/files#diff-5(9)

Patch Links:

• https://github.com/cdevr/WapSNMP/pull/1.patch
• https://github.com/cdevr/WapSNMP/pull/1.diff

[cdevr]

Just to keep you up to date : I'm working on extending this patch. It needs testing, the encryption code does not look entirely in the correct place and as you said it should be completed.

It's too bad the code isn't split up in multiple pull requests too. The ber.go changes for example should be able to go in directly without any modification. Oh well, that's probably just me not knowing too much about git.

Thanks

On Thu, Nov 14, 2013 at 9:28 AM, Christophe Devriese < [email protected]> wrote:

Nice I'll take a look at it tomorrow. I'm currently travelling.

Thanks !

On Wed, Nov 13, 2013 at 10:27 PM, tiebingzhang [email protected]:

Hi,

I have added some basic SNMP V3 support to your WapSNMP project. The V3 is implemented along with V1 and V2C. Right now only GetNext is implemented, but the rest can be implemented in a similar way. Would you like to pull and merge this into your repository?

Best regards,

Tiebing

You can merge this Pull Request by running

git pull https://github.com/tiebingzhang/WapSNMP master

Or view, comment on, or merge it at:

https://github.com/cdevr/WapSNMP/pull/1 Commit Summary

• V3 GetNext working
• removed debug messages
• updated README
• aes/des md5/sha1 all working now
• added the simple test file under utils

File Changes

• M README.md https://github.com/cdevr/WapSNMP/pull/1/files#diff-0(2)
• M ber.go https://github.com/cdevr/WapSNMP/pull/1/files#diff-1(33)
• M example.gohttps://github.com/cdevr/WapSNMP/pull/1/files#diff-2(52)
• M snmp.go https://github.com/cdevr/WapSNMP/pull/1/files#diff-3(394)
• M utils/getTable.gohttps://github.com/cdevr/WapSNMP/pull/1/files#diff-4(9)
• A utils/test.gohttps://github.com/cdevr/WapSNMP/pull/1/files#diff-5(9)

Patch Links:

• https://github.com/cdevr/WapSNMP/pull/1.patch
• https://github.com/cdevr/WapSNMP/pull/1.diff

[tiebingzhang]

Thanks for keeping me posted. Sorry about the combined git pull request. This is my first git pull request ever, so I am really new to git collaboration. I will pay attention to the git pull request next time.

I hope you can use some of the code. I did it in a rush to get some basic V3 capabilities in. It still needs a lot of work to fit in your original code layout (by the way, very nice code layout). I look forward to seeing the new code.

Best regards,

Tiebing

On Sat, Nov 16, 2013 at 9:35 PM, cdevr [email protected] wrote:

Just to keep you up to date : I'm working on extending this patch. It needs testing, the encryption code does not look entirely in the correct place and as you said it should be completed.

It's too bad the code isn't split up in multiple pull requests too. The ber.go changes for example should be able to go in directly without any modification. Oh well, that's probably just me not knowing too much about git.

Thanks

On Thu, Nov 14, 2013 at 9:28 AM, Christophe Devriese < [email protected]> wrote:

Nice I'll take a look at it tomorrow. I'm currently travelling.

Thanks !

On Wed, Nov 13, 2013 at 10:27 PM, tiebingzhang <[email protected] wrote:

Hi,

I have added some basic SNMP V3 support to your WapSNMP project. The V3 is implemented along with V1 and V2C. Right now only GetNext is implemented, but the rest can be implemented in a similar way. Would you like to pull and merge this into your repository?

Best regards,

Tiebing

You can merge this Pull Request by running

git pull https://github.com/tiebingzhang/WapSNMP master

Or view, comment on, or merge it at:

https://github.com/cdevr/WapSNMP/pull/1 Commit Summary

• V3 GetNext working
• removed debug messages
• updated README
• aes/des md5/sha1 all working now
• added the simple test file under utils

File Changes

• M README.md <https://github.com/cdevr/WapSNMP/pull/1/files#diff-0 (2)
• M ber.go https://github.com/cdevr/WapSNMP/pull/1/files#diff-1(33)
• M example.go<https://github.com/cdevr/WapSNMP/pull/1/files#diff-2 (52)
• M snmp.go <https://github.com/cdevr/WapSNMP/pull/1/files#diff-3 (394)
• M utils/getTable.go< https://github.com/cdevr/WapSNMP/pull/1/files#diff-4>(9)
• A utils/test.go< https://github.com/cdevr/WapSNMP/pull/1/files#diff-5>(9)

Patch Links:

• https://github.com/cdevr/WapSNMP/pull/1.patch
• https://github.com/cdevr/WapSNMP/pull/1.diff

— Reply to this email directly or view it on GitHubhttps://github.com/cdevr/WapSNMP/pull/1#issuecomment-28643068 .

[codewithleap]

Great library! Any update on adding SNMPv3?

[merinjo]

Is it possible to give an input the authkey and secretkey as hex byte rather than passing in the pass phrases? I can see that the code converts the pass words to key bytes. But want to directly input the auth and privKey. @tiebingzhang @cdevr