spec icon indicating copy to clipboard operation
spec copied to clipboard

Define every `url` and `viewUrl` field as format `uri`

Open davidB opened this issue 2 years ago • 3 comments

Changes

  • define every fields url and viewUrl with format: "uri" as proposed in #191
  • as the version of schema was with suffix -draft, I didn't update them

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

davidB avatar Apr 07 '24 15:04 davidB

Thanks @davidB - we discussed this topic during the last CDEvents WG and we plan to include it in the next milestone v0.5. We'll try to have most of the breaking changes in one milestone (v0.5). Once the v0.4 release is out (this week), this PR will have to be rebased and the version of the affected events updated.

afrittoli avatar Apr 09 '24 11:04 afrittoli

@davidB - main is now open for v0.5 development - could you rebase your PR based on top of the updated main? @xibz @obowersa this PR is related to #162 and cleanup/consistency work we plan for v0.5.

afrittoli avatar Apr 12 '24 09:04 afrittoli

@afrittoli The PR is rebased on main.

davidB avatar Oct 05 '24 14:10 davidB

We should rename URL to URIs

@xibz I renamed every field named url into uri. But kept viewUrl as is.

davidB avatar Nov 19 '24 13:11 davidB

@xibz / @afrittoli Can you merge the PR (I'm not allowed).

davidB avatar Dec 04 '24 15:12 davidB