termonad icon indicating copy to clipboard operation
termonad copied to clipboard

make default blue color lighter

Open cdepillabout opened this issue 4 years ago • 4 comments

The default blue color in Termonad is quite dark. If you have text in the default blue color, it is quite hard to read on a terminal with a dark background.

Termonad just provides the default colors from VTE, but it would be nice to deviate from the default VTE colors and provide a blue that is lighter, since the background color in Termonad is dark by default.

I explain a little more about this in https://github.com/cdepillabout/termonad/issues/176#issuecomment-753558741.

Implementing this would basically require changing the following two functions to set a different blue color:

https://github.com/cdepillabout/termonad/blob/d8998e6f30b86103b55fa3117cf0f6f4c24b7e07/src/Termonad/Config/Colour.hs#L392-L404

cdepillabout avatar Jan 03 '21 13:01 cdepillabout

As mentioned in the other issue I would be careful with that since it can lead to ugly tui application. So if you try to change the default colors check if for example nmtui looks ok.

Since all cli programs I'm aware of only use blue text in combination with bold fonts I still think it would be easier to enable BoldIsBright by default to solve the problem with unreadable blue text.

M0M097 avatar Jan 03 '21 14:01 M0M097

Here are what the standard and light blue colors look like with the current Termonad defaults (taken from https://github.com/cdepillabout/termonad/pull/178#issuecomment-753711012):

image

You can see that they are a little too dark for a black background.

cdepillabout avatar Jan 04 '21 01:01 cdepillabout

Just wondering (not that it should stop termonad), has there been any attempt to address this upstream in libvte itself?

juhp avatar Jan 08 '21 02:01 juhp

@juhp That's a good point.

I took a quick look at the VTE issue tracker, but I didn't see any issues about it: https://gitlab.gnome.org/GNOME/vte/-/issues

It is possible that upstream VTE defaults to a white background, so they don't see this problem. It is also possible that Termonad is just using a different color of blue than VTE defaults to (although I'm pretty sure this is not the case). If someone wanted to create an issue upstream, it would probably be a good idea just to double check these two things.

cdepillabout avatar Jan 08 '21 03:01 cdepillabout