Dennis Gosnell

Results 200 comments of Dennis Gosnell

I tried looking into this a little more. Here's my reproduction of this issue: ![image](https://user-images.githubusercontent.com/64804/69394718-2b03b800-0d20-11ea-9c3d-d8c99414803f.png) You can see that everything after the final `)` gets lost. This happens because `pretty-simple`...

> There's no unbalanced parenthesis here – it's apparently just that the characters are misparsed. Ah, so like I said in https://github.com/cdepillabout/pretty-simple/issues/52#issuecomment-557365228, this is caused because of #45 and #27....

@andrew-lei Would you be able to review this one as well? If it looks good, you can merge it and make a new release if you want. Here is a...

@dminuoso `pretty-simple` is designed for data types with a `Show` instance, but it is also designed to be more flexible than other pretty-printing libraries. It should try it's hardest to...

Here is an example of this failing to pretty-print something with non-balanced parenthesis: ```haskell $ ghci > import Text.Pretty.Simple > import Data.Text.Lazy > putStrLn $ unpack $ pString "Just \"hello\"...

#52 is another instance of things being dropped after non-balanced parenthesis. This should really be fixed.

@Lev135 Thanks for submitting this issue! This is very likely a bug. Would you be able to send a PR fixing this?

In general I would like pretty-simple to change the input as little as possible. (Well, aside from formatting!) So ideally it wouldn't drop (or not print) anything that is in...

@andrew-lei Thanks for the clarification. I actually just tried running `pString` on the input from above, and it looks like the last bracket is droped: ```haskell > Data.Text.Lazy.IO.putStrLn $ pString...

> Actually, now that I think about it, seems like that pattern could be used for all of these. The only issue might be that some of them keep the...