Christoph Deil

Results 472 comments of Christoph Deil

Please make one PR adding all `info.yaml` files. Also I have close to zero time to review, so please check the diff yourself before submitting the PR. The main things...

@pdeiml - Please add what you can, and leave the few you're unsure about somewhere in a reminder issue. Leave both of those out for now. Then we can look...

@micheledoro @elisaprandini - It's great that you want to contribute MAGIC data to gamma-cat. > In addition, were the HESS and VERITAS data information cross-checked before entering the gamma-cat database?...

I've removed `docs/data/sources/000132/gammacat_000132_2007A%26A...472..489A_sed.ecsv`, which was an SED file put for the wrong source 132 as a result of the data entry error mentioned above in 4e5352e .

How about adding the files from `input/sources` to the input index file as well (and then also to the output and output index)? That data is also needed to make...

> Do you want to copy the input/sources files to docs/data as well? Yes. It should be scripted in the same way as SED and LC: there should be a...

For spectral points, we do support upper limits, but not systematic errors: http://gamma-astro-data-formats.readthedocs.io/en/latest/spectra/flux_points/index.html For spectral models, we do currently have an `err_sys` field, but no asymmetric systematic errors or upper...

This is the HDUs and columns of @woodmd's example file: https://gist.github.com/cdeil/d80329334e0085f8959c37b34181e718 @woodmd - In general, I do think it would be very valuable to write down a spec for the...

For now, I've introduced completely separate columns for the spectral models that we support: https://github.com/gammapy/gamma-cat/commit/2c0c279e04d55be4fbe6a9222998504188cb542c It makes the code that reads and writes the catalog (and instantiates model objects from...

@GernotMaier - Looks like we don't have one of those at the moment, but it's easy to add support for it in the gamma-cat schema file and scripts. Can you...