Marc Mueller

Results 381 comments of Marc Mueller

Sorry for the late reply. I somehow lost track of it. > I think that this is very reasonable. Can we somehow re-use the existing definition? > > https://github.com/abravalheri/validate-pyproject/blob/v0.24.1/src/validate_pyproject/plugins/setuptools.schema.json#L251-L261? Unless...

@abravalheri Did you had a chance to look at this again?

> I am not sure I follow. I tested the following snippet for `package-data` and `exclude-package-data` on top of [4b72449](https://github.com/abravalheri/validate-pyproject/commit/4b7244937eea1a5bcd1c64377920009a19e14dc0) and the added tests seem to pass as expected: >...

> So if I understand correctly, the error you are concerned about is when the person writes `some-project` but the actual directory uses underscore instead of dashes (or vice versa)......

Thanks for the detailed explanation! It seems I've got some things messed up along the way. If I understand you correctly, your suggestion is to reuse the `package-name` definition, which...

It anything missing here? Both test failures seem to be unrelated.

@WillAyd Would you mind taking a quick look at this? It's just a backport PR.

@rhshadrach @WillAyd Small ping. Anything I can help with to get this over the finish line? It's just a 4 line change backport PR after all.