Marc Mueller

Results 381 comments of Marc Mueller

/CC @bethanyj28 Would you mind taking a look at this one? It fixes a bug which was just recently introduced.

> This seems reasonable to me. Could you add a test case in https://github.com/actions/cache/blob/main/__tests__/restoreImpl.test.ts to validate? Thank you! I thought about that but I'm not really sure how to do...

@bethanyj28 Would you mind tagging the `4.0.2` release? It would be awesome if this bug would finally be fixed. I already updated the version in `package.json` and the changelog in...

> Should we then ignore the rule completely? I think the introduction in #113015 was not seen as a problem because the explicit `else` was rarely used. > I don't...

> More interesting, there is a difference between mypy 1.0.1 and the latest from GitHub. They do the opposite. The current mypy master breaks the pydantic mypy plugin. See #5077...

> @cdce8p I've tried [your fix on mypy](https://github.com/python/mypy/pull/14734) with #5077, but it doesn't fix the problem on `1.10.x` and `V2` That fix only restores the state of `1.0.1`. I.e. the...

> > That fix only restores the state of `1.0.1`. I.e. the only error should be > > ``` > > test.py:9: error: Unexpected keyword argument "alias" for "Model" [call-arg]...

Possible fix: #5162 Until now, the plugin manually applied the dataclass transform to pydantic dataclasses. This isn't necessary anymore with mypy `1.1.1` and the `@dataclass_transform` decorator as it also applies...

Seems like `InitVar` causes the crash with pydantic `v2` and mypy. Not sure why

My original intent was to fix the missing spine. I discovered that it's still possible to go your original route via `spineWidth` and `normalPages` if you get those parameter from...