netty-http icon indicating copy to clipboard operation
netty-http copied to clipboard

Portability to Java 6 support

Open fredericBregier opened this issue 5 years ago • 9 comments

This framework should be able to be binary compatible with Java 6 as Netty does. This merge request allows minor changes to be able to be compatible.

Also it upgrades dependencies.

All changes made by @marakiis

Issue reference #73

fredericBregier avatar Jun 18 '19 11:06 fredericBregier

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

googlebot avatar Jun 18 '19 11:06 googlebot

Signed the CLA @marakiis Maybe you should too

fredericBregier avatar Jun 18 '19 11:06 fredericBregier

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

googlebot avatar Jun 18 '19 11:06 googlebot

I looked at the build from travis: it seems broken for long time, but on maven specification

<packaging>bundle</packaging>

So not related to this pull request.

fredericBregier avatar Jun 18 '19 11:06 fredericBregier

I correct this PR as your review. I unterstand that keeping Java6 compatibility is a bit "old", but we (in our project) will move to Java7 and upward next year. In the meantime, we need Java6 compatibility. We hope those changes are very small and not being too ugly.

fredericBregier avatar Jun 19 '19 10:06 fredericBregier

It is better not to merge to develop branch, but rather a special branch for java 6 support only, so that we can release a special artifact for Java 6 only. In this way, it won’t affect the regular release of the Java 8 code base

chtyim avatar Jun 19 '19 15:06 chtyim

@chtyim Why not... As you wish. I will wait for your guidance.

The idea is to benefit of the project and to participate as much as we can too.

Maybe we could make after another PR with only the dependencies upgrade and the add of OPTIONS on develop?

fredericBregier avatar Jun 19 '19 18:06 fredericBregier

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

googlebot avatar Oct 30 '19 14:10 googlebot

Time to close this perhaps seeing it is moving nowhere? Too bad about the effort involved, but guessing Fred used this locally and has since upgraded the project to Java 7 (or 17?) 😄

fatso83 avatar Apr 19 '22 15:04 fatso83