CDAP-19465 Replacing kill() functionality by clean()

[ameya0111]

Logs when program finishes successfully in tethered mode -

2022-09-16 05:47:27,160 - DEBUG [program-start-1:i.c.c.d.u.h.HBaseVersion@244] - HBase is not available from the environment. Cannot determine HBase version.
2022-09-16 05:47:27,161 - DEBUG [program-start-1:i.c.c.i.a.r.d.DistributedProgramRunner@803] - No HBase dependencies to add.
2022-09-16 05:47:27,263 - DEBUG [program-start-1:i.c.c.k.r.KubeTwillPreparer@909] - Create and copy service : file:/data/tmp/1663307245430-0/cConf.xml
2022-09-16 05:47:27,444 - DEBUG [program-start-1:i.c.c.k.r.KubeTwillPreparer@912] - Done service : file:/data/tmp/1663307245430-0/cConf.xml
2022-09-16 05:47:27,496 - DEBUG [program-start-1:i.c.c.k.r.KubeTwillPreparer@909] - Create and copy service : file:/etc/cdap/conf/logback-container.xml
2022-09-16 05:47:27,657 - DEBUG [program-start-1:i.c.c.k.r.KubeTwillPreparer@912] - Done service : file:/etc/cdap/conf/logback-container.xml
2022-09-16 05:47:27,691 - DEBUG [program-start-1:i.c.c.k.r.KubeTwillPreparer@909] - Create and copy service : file:/data/tmp/1663307245430-0/1663307245614-0/artifacts.jar
2022-09-16 05:47:28,438 - DEBUG [program.status:i.c.c.i.a.r.d.r.RemoteExecutionTwillController@138] - Clean up of remote process for program run program_run:default.tether1.-SNAPSHOT.workflow.DataPipelineWorkflow.8a73aa11-3582-11ed-bef6-f2627761eec2
2022-09-16 05:47:28,439 - DEBUG [program.status:i.c.c.i.a.r.d.r.RuntimeJobRemoteProcessController@81] - Cleaning up program run program_run:default.tether1.-SNAPSHOT.workflow.DataPipelineWorkflow.8a73aa11-3582-11ed-bef6-f2627761eec2
2022-09-16 05:47:28,445 - DEBUG [program.status:i.c.c.i.t.r.s.r.TetheringRuntimeJobManager@162] - No-op cleanup for program ProgramRunInfo{namespace='default', application='tether1', version='-SNAPSHOT', programType='WORKFLOW', program='DataPipelineWorkflow', run='8a73aa11-3582-11ed-bef6-f2627761eec2'}
2022-09-16 05:47:28,476 - DEBUG [program.status:i.c.c.i.p.t.ProvisioningTask@86] - Created DEPROVISION task for program run program_run:default.tether1.-SNAPSHOT.workflow.DataPipelineWorkflow.8a73aa11-3582-11ed-bef6-f2627761eec2.
2022-09-16 05:47:28,495 - DEBUG [provisioning-task-1:i.c.c.i.p.t.ProvisioningTask@125] - Executing DEPROVISION subtask REQUESTING_DELETE for program run program_run:default.tether1.-SNAPSHOT.workflow.DataPipelineWorkflow.8a73aa11-3582-11ed-bef6-f2627761eec2.
2022-09-16 05:47:28,496 - DEBUG [provisioning-task-1:i.c.c.i.p.t.ProvisioningTask@129] - Completed DEPROVISION subtask REQUESTING_DELETE for program run program_run:default.tether1.-SNAPSHOT.workflow.DataPipelineWorkflow.8a73aa11-3582-11ed-bef6-f2627761eec2.
2022-09-16 05:47:28,600 - DEBUG [provisioning-task-0:i.c.c.i.p.t.ProvisioningTask@116] - Completed DEPROVISION task for program run program_run:default.tether1.-SNAPSHOT.workflow.DataPipelineWorkflow.8a73aa11-3582-11ed-bef6-f2627761eec2.
2022-09-16 05:47:30,630 - DEBUG [program-start-1:i.c.c.k.r.KubeTwillPreparer@912] - Done service : file:/data/tmp/1663307245430-0/1663307245614-0/artifacts.jar
2022-09-16 05:47:30,662 - DEBUG [program-start-1:i.c.c.k.r.KubeTwillPreparer@909] - Create and copy service : file:/data/tmp/1663307245430-0/appSpec244617500569484490.json
2022-09-16 05:47:30,841 - DEBUG [program-start-1:i.c.c.k.r.KubeTwillPreparer@912] - Done service : file:/data/tmp/1663307245430-0/appSpec244617500569484490.json
2022-09-16 05:47:30,885 - DEBUG [program-start-1:i.c.c.k.r.KubeTwillPreparer@909] - Create and copy service : file:/data/tmp/service.system.dataprep.service.08c2de92-3583-11ed-8473-f2627761eec2/program.jar
2022-09-16 05:47:33,358 - DEBUG [program-start-1:i.c.c.k.r.KubeTwillPreparer@912] - Done service : file:/data/tmp/service.system.dataprep.service.08c2de92-3583-11ed-8473-f2627761eec2/program.jar
2022-09-16 05:47:33,405 - DEBUG [program-start-1:i.c.c.k.r.KubeTwillPreparer@909] - Create and copy service : file:/data/tmp/1663307245430-0/hConf.xml
2022-09-16 05:47:33,614 - DEBUG [program-start-1:i.c.c.k.r.KubeTwillPreparer@912] - Done service : file:/data/tmp/1663307245430-0/hConf.xml
2022-09-16 05:47:33,661 - DEBUG [program-start-1:i.c.c.k.r.KubeTwillPreparer@909] - Create and copy service : file:/data/tmp/1663307245430-0/1663307245614-0/artifacts.jar
2022-09-16 05:47:40,181 - DEBUG [program-start-1:i.c.c.k.r.KubeTwillPreparer@912] - Done service : file:/data/tmp/1663307245430-0/1663307245614-0/artifacts.jar
2022-09-16 05:47:40,240 - DEBUG [program-start-1:i.c.c.k.r.KubeTwillPreparer@909] - Create and copy service : file:/data/tmp/1663307245430-0/program.options2420381179233932434.json
2022-09-16 05:47:40,423 - DEBUG [program-start-1:i.c.c.k.r.KubeTwillPreparer@912] - Done service : file:/data/tmp/1663307245430-0/program.options2420381179233932434.json
2022-09-16 05:47:40,461 - DEBUG [program-start-1:i.c.c.k.r.KubeTwillPreparer@835] - Saving twill specification for service.system.dataprep.service to /tmp/runtime.config.jar290541846354934103/twillSpec.json

[gitpod-io[bot]]

[chtyim]

The change seems hacky. Do we have a better way?

[ameya0111]

The change seems hacky. Do we have a better way?

Based on discussions with masoud-io and albertshau, we considered a solution around -https://cdap.atlassian.net/browse/CDAP-18739

In this case, the kill() method here - https://github.com/cdapio/cdap/blob/ba358eed7c8b71502633e98197c8daad7ab3efd4/cdap-app-fabric/src/main/java/io/cdap/cdap/internal/tethering/runtime/spi/runtimejob/TetheringRuntimeJobManager.java#L146 would execute correctly and take care of the current issue as well.

But 18739 is currently not being considered.

[ameya0111]

This PR has been handled by https://github.com/cdapio/cdap/pull/14540