cdap icon indicating copy to clipboard operation
cdap copied to clipboard

Add colon to accepted chars for dataset id

Open mrahanjam opened this issue 2 years ago • 6 comments

This PR adds colon to the accepted chars for dataset id

JIRA: CDAP-19519

mrahanjam avatar Aug 22 '22 23:08 mrahanjam

gitpod-io[bot] avatar Aug 22 '22 23:08 gitpod-io[bot]

Are we using colon as a separator for fqn? For gcp resources it is something like "projects/{project}/...", will the DC integration replace colon with expected character? How will it know when to replace it?

yaojiefeng avatar Sep 02 '22 20:09 yaojiefeng

is there a way to find out if thats the case anywhere?

avirmani avatar Sep 02 '22 20:09 avirmani

Are we using colon as a separator for fqn? For gcp resources it is something like "projects/{project}/...", will the DC integration replace colon with expected character? How will it know when to replace it?

They start with pluginName followed by ":". For example GCS is gs://{bucket name}{path} and BQ is bigquery:myProject.myDataset.myTable.

mrahanjam avatar Sep 02 '22 21:09 mrahanjam

is it possible to add a new field for FQN rather than use the dataset id? This would be safer, but I'm not sure if it would allow us to meet all the requirements for this project.

albertshau avatar Sep 02 '22 21:09 albertshau

is it possible to add a new field for FQN rather than use the dataset id? This would be safer, but I'm not sure if it would allow us to meet all the requirements for this project.

@snehalakshmisha do you think we can do this?

mrahanjam avatar Sep 02 '22 21:09 mrahanjam