cdap-ui icon indicating copy to clipboard operation
cdap-ui copied to clipboard

Published 20 hours ago • verified publisher icon cdapio

[CDAP-20193] Version comparison for LCM

Open sumengwang opened this issue 2 years ago • 4 comments

CDAP-20193 Version comparison for LCM

Description

added basic view to compare the configuration json of selected version against latest version.

PR Type

  • [ ] Bug Fix
  • [x] Feature
  • [ ] Build Fix
  • [ ] Testing
  • [ ] General Improvement
  • [ ] Cherry Pick

Links

Jira: CDAP-20193

Screenshots

image

image

image

sumengwang avatar Dec 13 '22 23:12 sumengwang

This is amazing!

de-lan avatar Dec 13 '22 23:12 de-lan

Is there a design for this? Why not put the + and - at the beginning of the line like github uses?

seanfeld avatar Dec 16 '22 03:12 seanfeld

Is there a design for this? Why not put the + and - at the beginning of the line like github uses?

no there's no design. We just have an idea that we want to show diff. I'm kinda improvising here

sumengwang avatar Dec 16 '22 03:12 sumengwang

Is there a design for this? Why not put the + and - at the beginning of the line like github uses?

no there's no design. We just have an idea that we want to show diff. I'm kinda improvising here

No worries it already looks great so good job so far.

Screen Shot 2022-12-15 at 7 42 46 PM Can we add the + - like in github then?

seanfeld avatar Dec 16 '22 03:12 seanfeld