Chris Danis comments

Results 17 comments of


                                            Chris Danis

permalinks: add a few bits to what's accepted in a URL, populate history events, add a copy to clipboard button

I believe this is good to go. As requested, it's a button, and I also figured out the History API enough for it to Do The Right Thing on any...

permalinks: add a few bits to what's accepted in a URL, populate history events, add a copy to clipboard button

friendly ping :)

permalinks: add a few bits to what's accepted in a URL, populate history events, add a copy to clipboard button

@Nightfirecat @april any chance you'll be able to take a look soon? Once this is merged I'd like to modify PDF output to include a hyperlink to the permalink URL,...

permalinks: add a few bits to what's accepted in a URL, populate history events, add a copy to clipboard button

Are you talking about 81c6883, e8c0353, and ea08763? I think those are appearing here as a result of a merge commit. I don't think they will cause any effect if...

permalinks: add a few bits to what's accepted in a URL, populate history events, add a copy to clipboard button

Oh. Hm. Now I see what you're talking about, and I'm not sure how that happened. I'll fix.

permalinks: add a few bits to what's accepted in a URL, populate history events, add a copy to clipboard button

I've rebased this on your current gh-pages and I think it's good to go now.

[pkg/ottl] Parse uri string to url.* SemConv attributes

I've been writing a lot of OTTL lately and I found myself wanting exactly this functionality as a user convenience. Fully-compliant URL parsing is definitely non-trivial, and IMO worth implementing...