mqt-qmap icon indicating copy to clipboard operation
mqt-qmap copied to clipboard

✨ Neutral Atom Mapper

Open ystade opened this issue 1 year ago • 3 comments

Description

This is the start of a mapper tailored to the neutral atom platform. Peculiarities are global gates and shuttling of atoms, among others.

Checklist:

  • [ ] The pull request only contains commits that are related to it.
  • [ ] I have added appropriate tests and documentation.
  • [ ] I have made sure that all CI jobs on GitHub pass.
  • [ ] The pull request introduces no new warnings and follows the project's style guidelines.

ystade avatar Jan 24 '24 19:01 ystade

@burgholzer Thanks for the helpful review, this was exactly the degree of detail I was looking for.

ystade avatar Feb 01 '24 15:02 ystade

Codecov Report

Attention: Patch coverage is 93.10114% with 103 lines in your changes are missing coverage. Please review.

Project coverage is 90.4%. Comparing base (b365106) to head (dc14583).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main    #417     +/-   ##
=======================================
+ Coverage   89.8%   90.4%   +0.6%     
=======================================
  Files         61      68      +7     
  Lines       6358    7851   +1493     
  Branches    1008    1277    +269     
=======================================
+ Hits        5711    7101   +1390     
- Misses       647     750    +103     
Flag Coverage Δ
cpp 90.0% <93.1%> (+0.7%) :arrow_up:
python 95.9% <ø> (ø)
Files Coverage Δ
include/na/Architecture.hpp 100.0% <100.0%> (ø)
include/na/Configuration.hpp 100.0% <100.0%> (ø)
include/na/NAMapper.hpp 100.0% <100.0%> (ø)
src/na/Configuration.cpp 94.4% <94.4%> (ø)
src/na/Architecture.cpp 98.8% <98.8%> (ø)
src/na/NAGraphAlgorithms.cpp 92.9% <92.9%> (ø)
src/na/NAMapper.cpp 89.8% <89.8%> (ø)

codecov[bot] avatar Apr 23 '24 15:04 codecov[bot]

Hey @ystade 👋🏼 I took the liberty of going through the Architecture class and simplifying a couple of things in there. While some of these changes are only minor and could be considered cosmetic, at least on my machine, the tests show a significant speed-up from roughly 160ms -> 90ms. Would be interesting to see how this turns out in real experiments.

burgholzer avatar May 01 '24 13:05 burgholzer