fiction
fiction copied to clipboard
✨ Defect-aware on-the-fly SiDB circuit designer
Description
This PR adds the defect-aware on-the-fly SiDB circuit designer
and supports all 2 input functions.
Checklist:
- [x] The pull request only contains commits that are related to it.
- [x] I have added appropriate tests and documentation.
- [ ] I have made sure that all CI jobs on GitHub pass.
- [ ] The pull request introduces no new warnings and follows the project's style guidelines.
Codecov Report
Attention: Patch coverage is 96.50350%
with 25 lines
in your changes are missing coverage. Please review.
Project coverage is 98.17%. Comparing base (
9becc3a
) to head (dc25546
).
Additional details and impacted files
@@ Coverage Diff @@
## main #317 +/- ##
==========================================
- Coverage 98.32% 98.17% -0.15%
==========================================
Files 209 216 +7
Lines 28308 29012 +704
Branches 1290 1372 +82
==========================================
+ Hits 27834 28483 +649
- Misses 474 529 +55
Files | Coverage Δ | |
---|---|---|
.../algorithms/physical_design/apply_gate_library.hpp | 100.00% <100.00%> (ø) |
|
.../fiction/algorithms/simulation/sidb/quickexact.hpp | 98.78% <100.00%> (ø) |
|
include/fiction/layouts/coordinates.hpp | 100.00% <100.00%> (ø) |
|
include/fiction/layouts/gate_level_layout.hpp | 99.77% <100.00%> (+<0.01%) |
:arrow_up: |
include/fiction/networks/technology_network.hpp | 100.00% <100.00%> (ø) |
|
...ude/fiction/technology/inml_topolinano_library.hpp | 89.47% <ø> (ø) |
|
...tion/technology/is_sidb_gate_design_impossible.hpp | 100.00% <100.00%> (ø) |
|
include/fiction/technology/qca_one_library.hpp | 87.93% <ø> (ø) |
|
...clude/fiction/technology/sidb_bestagon_library.hpp | 95.31% <ø> (ø) |
|
include/fiction/technology/sidb_defect_surface.hpp | 100.00% <100.00%> (ø) |
|
... and 22 more |
... and 2 files with indirect coverage changes
Continue to review full report in Codecov by Sentry.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 9becc3a...dc25546. Read the comment docs.
clang-tidy review says "All clean, LGTM! :+1:"
clang-tidy review says "All clean, LGTM! :+1:"
The Windows CI failing is not your fault. It stems from the changes I made to the technology mapper interface. MSVC seems to have issues with the mockturtle::map
function. I haven't figured out a fix yet. Don't worry about it right now.
The Windows CI failing is not your fault. It stems from the changes I made to the technology mapper interface. MSVC seems to have issues with the
mockturtle::map
function. I haven't figured out a fix yet. Don't worry about it right now.
@marcelwa Do you already have an idea how to solve this? Thank you!
The Windows CI failing is not your fault. It stems from the changes I made to the technology mapper interface. MSVC seems to have issues with the
mockturtle::map
function. I haven't figured out a fix yet. Don't worry about it right now.@marcelwa Do you already have an idea how to solve this? Thank you!
Unfortunately, I do not.
@Drewniok this PR can now be updated with the latest changes from main
. Its tests should now pass 👍
@marcelwa Great! Thank you for your hard work!