ccxt
New Exchange: trbinance (binance turkey)
Currently has the following public methods are available and working:
- fetchMarkets
- fetchTime
- fetchOrderBook
The following are also supported by the exchange but have not been added yet:
- Trades
- Klines
[fix #8122]
Cool, i'd suggest that we can pretty much merge this as is now and will reach out to the binancetr team for an apiKey
ok great! However, I also added the fetchTradres that gets a response correctly but isn't parsing the reply yet. Do you prefer if I remove the fetchTrades first and then merge, or you can merge as it is?
We can wait for this to be complete, I was just suggesting to merge it before we finish the private api
@criadoperez let me know if you can fix this build or if you have any questions on it: https://app.travis-ci.com/github/ccxt/ccxt/builds/244474083#L8429
Yes, I should be able to fix it and add new functions. I'll get to it on monday.
With all the public endpoints working and build and test success, I suggest we merge this PR and make a new PR for the private part once keys are received (it could be a while)...
@criadoperez unfortunately, we can't really merge partial integrations, CCXT says that if the exchange is integrated – it is more or less complete with both the public and the private apis. I'd suggest that we finish both parts in this PR, it will be easier to review and merge this way.
@frosty00 the following commit already builds locally. Its still missing functionally, so test may fail. I'll convert this PR to draft until it's fully functional.
