brute38 icon indicating copy to clipboard operation
brute38 copied to clipboard

default number of threads should be number of physical cores, not logical

Open grr opened this issue 7 years ago • 1 comments

the default number of threads should be set to the number of physical cores, not logical cores. If you have a 4 core machine with hyperthreads, the default number of threads is 8. This is actually a bit slower than if 4 threads were used, since each core is already fully utilized and the extra 4 threads incur extra context switching.

grr avatar Nov 08 '18 22:11 grr

Yeah you're right. I'll look at modifying this code. Not sure if go provides a platform-neutral mechanism to detect this but I'll lookk into it (it's been a while since I programmed in go).

cculianu avatar Nov 09 '18 00:11 cculianu