cctbx_project icon indicating copy to clipboard operation
cctbx_project copied to clipboard

Fix bug in merging_statistics.as_cif_block function

Open jbeilstenedmands opened this issue 3 years ago • 6 comments

Upon iterating through the name dict, the test for finding the string 'percent' should be on the keys, not the values.

Added a line to a test to verify. This issue means that when the merging stats were converted to a cif block, the _reflns.percent_possible_obs item has been in the range 0 -> 1 rather than 0 -> 100 as intended.

jbeilstenedmands avatar Jun 02 '21 15:06 jbeilstenedmands

/azp run Full

bkpoon avatar Jun 02 '21 18:06 bkpoon

/azp run Base

bkpoon avatar Jun 02 '21 18:06 bkpoon

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Jun 02 '21 18:06 azure-pipelines[bot]

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Jun 02 '21 18:06 azure-pipelines[bot]

Looks good to me, thanks!

Can be merged once @rjgildea approves.

bkpoon avatar Jun 15 '21 19:06 bkpoon

@rjgildea just noticed this is still open, care to take a quick look over?

jbeilstenedmands avatar Mar 02 '22 12:03 jbeilstenedmands