LocalSTT icon indicating copy to clipboard operation
LocalSTT copied to clipboard

Consider pulling en-US changes

Open ewheelerinc opened this issue 2 years ago • 6 comments

See the commits, there are a few changes to support Android 11.

Also, English is pretty common throughout the world, please consider merging the en-US models to invite additional testing and development.

ewheelerinc avatar Jan 19 '22 00:01 ewheelerinc

Hi Eric!

Thank you very much for looking into the Android 11 issues, I understand it now works?

There are a lot of changes in your PR, I will make time to review it and merge it. There are some references to your fork in the README which should be updated if we want to merge it here.

As for packaging one language or another, I think it'd be even better if pre-built binaries for all models available are published, English might be pretty common, but it is not everyone's native language. I have been thinking on maybe building the APK in a GitHub action. At least until someone adds the possibility to download them from within the APK.

ccoreilly avatar Jan 19 '22 21:01 ccoreilly

There is also https://github.com/alphacep/vosk-android-service which will have a download UI for vosk models

ccoreilly avatar Jan 19 '22 21:01 ccoreilly

Does vosk-android-service supersede LocalSTT?

ewheelerinc avatar Jan 19 '22 21:01 ewheelerinc

Does vosk-android-service supersede LocalSTT?

Maybe?

LocalSTT was never meant to be more than a PoC and I do not have time to work on it for now. I would personally like to have a FOSS app for local stt supporting different models, not just vosk (coqui stt, wenet, maybe others), which does not seem the goal of vosk-android-service. However, it looks like vosk-android-service is aiming at offering a good UX and the vosk models are pretty good.

ccoreilly avatar Jan 19 '22 22:01 ccoreilly

Thank you very much for looking into the Android 11 issues, I understand it now works?

It works with AnySoftKeyboard (or was it OpenBoard?) and it loads properly, but doesn't work with other common keyboards using the "microphone" icon. Not sure how AnySoft is different. These are the commits that fix it for Android 11:

  • 9ffb072
  • 97cd1fd - use this tool to repack the .apk after building, may need modified for your privkey and paths and such.

There are a lot of changes in your PR, I will make time to review it and merge it. There are some references to your fork in the README which should be updated if we want to merge it here.

That is fine, I don't need to be referenced necessarily, I just wanted to point at the en-US build if it helps others.

Andrey made a few changes, I originally cloned from his branch. Notably he removed DeepSpeech because of build issues. You said you'd like to see a multi-spech-backend app, so you might revert the DeepSpeech removal and try to fix the build: https://github.com/andreytkachenko/LocalSTT

As for packaging one language or another, I think it'd be even better if pre-built binaries for all models available are published, English might be pretty common, but it is not everyone's native language. I have been thinking on maybe building the APK in a GitHub action. At least until someone adds the possibility to download them from within the APK.

Agreed.

This commit is already in master. I understand you rebased your changes, which changed the commit hash. Consider squashing your changes so we don't end with duplicate commits.

Sorry, which commit? I can rebase if you like, but you might want to look through my changes and see which ones you actually want.

ewheelerinc avatar Jan 20 '22 21:01 ewheelerinc

This pull request will support english stt ? We should merge it.

AhmedX6 avatar Jan 24 '23 11:01 AhmedX6