boardgamegeek4android icon indicating copy to clipboard operation
boardgamegeek4android copied to clipboard

Published 20 hours ago • verified publisher icon ccomeaux

Dark mode for Android 10+

Open lehenry opened this issue 4 years ago • 6 comments
trafficstars

Use background color in splash screen, Add force dark allowed for Android API 29+ (follows the user theme) Night color scheme for 'light blue' to fix row dividers Screenshot_1607779471 Screenshot_1607779734

lehenry avatar Dec 12 '20 13:12 lehenry

Great idea! 👌 🤩 Is it difficult to make it Android 9+? 🤔

Kaligula0 avatar Dec 12 '20 19:12 Kaligula0

@Kaligula0 yes, it would be a bit more complicated, with Android 10, there is no need for a specific setting, there is a system flag for the dark mode, and I didn't wrote a full theme, the dark mode convert (almost) all colors by itself. I took the lazy path 😉

lehenry avatar Dec 12 '20 20:12 lehenry

I'd stick with dark mode for the more recent Android versions only, as usage of older versions than Android 10 should be limited and declining. Furthermore, it keeps this PR simple.

erikhuizinga avatar Aug 12 '21 08:08 erikhuizinga

@erikhuizinga I know, I know… I just love dark mode but my phone development finished on Android 9 🤷 Nevertheless I am definitively for that Pull request!

Kaligula0 avatar Sep 26 '21 17:09 Kaligula0

It can always be be developed for Android <= 9 (by you? 😉) after this PR is accepted.

erikhuizinga avatar Sep 27 '21 11:09 erikhuizinga

Is this PR still alive?

Kaligula0 avatar Jan 14 '24 21:01 Kaligula0