ccoVeille
ccoVeille
I would like you to consider upgrading golangci-lint to latest version, 1.51 is very old https://github.com/bwplotka/mdox/blob/main/.bingo/golangci-lint.mod current version is 1.59.1 https://golangci-lint.run/
Related to #795
you could define an interface with one method that will be implemented by each Logger (and do the same for Metrics) There is usually one thing that can be shared....
We may have to use ways to speed up the timer _Originally posted by @ccoVeille in https://github.com/gofr-dev/gofr/pull/831#pullrequestreview-2223167031_
Here is the list of errors I was able to detect via golangci-lint by enabling a lot of rules ``` 951 issues: * contextcheck: 12 * depguard: 2 * errorlint:...
I'm seeing a lot of defer like after calling a test helper Why not, adding a t.Cleanup to getMockMQTT and gomock.NewController And remove all this defer calls _Originally posted by...
The current code of createEnvFile has hardcoded "configs" in it. We could pass a folder as argument to createEnvFile. We can use another folder than configs and use t.TempDir to...
> 2 seconds is too long for tests _Originally posted by @ccoVeille in https://github.com/gofr-dev/gofr/pull/781#discussion_r1666561069_ > 3 seconds is like ages for tests _Originally posted by @ccoVeille in https://github.com/gofr-dev/gofr/pull/781#discussion_r1666563213_
the need of a discussion was raised during a code review something that is somehow standard now https://en.wikipedia.org/wiki/Well-known_URI https://github.com/moul/awesome-well-known https://www.iana.org/assignments/well-known-uris/well-known-uris.xhtml I'm unsure how people would be able to share such...
- **chore: use field name for setting struct** - **feat: add support for well known files**