ccoVeille

support known files

3

- **chore: use field name for setting struct** - **feat: add support for well known files**

add golangci-lint to project

6

I can help you in adding golangci-lint to your project and GitHub action workflow Please let me know if you are interested

Invalid language for project

2

When looking for project in GitHub you will see it reports the project is in C, while it's in Go  You have to use .`gitattributes` to exclude some folders...

empty: add Equal empty string

13

This pattern is common usef ```go assert.Equal(t, "", whatever) assert.Equal(t, ``, whatever) assert.Equal(t, "", string(whatever)) assert.Equal(t, ``, string(whatever)) assert.Empty(t, string(whatever)) ``` And it could be replaced ```go assert.Empty(t, whatever) ```...

Consider adding optional revive linters

3

I noticed than many of the code review I'm doing are about code simplification are about early-return pattern. I recommend using revive that could detect this pattern. early-return is one...

consider go-linter-runner project

5

I discovered this project yesterday https://github.com/alingse/go-linter-runner (hi @alingse :wave: ) @alingse popped out an issue on a repository I'm watching https://github.com/montanaflynn/stats/issues/84 @Antonboom I know you often look for regression/changes when...

Add NotElementsMatch

1

NotElementsMatch has just been added to the testify. https://github.com/stretchr/testify/pull/1600 It should be added to checker but also to : - useless assert https://github.com/Antonboom/testifylint/blob/master/internal%2Fcheckers%2Fuseless_assert.go#L34 - element match https://github.com/Antonboom/testifylint/blob/master/CONTRIBUTING.md#elements-match

error-nil: add Empty and Zero

2

we do not detect error used with empty/zero, right now ```go var err error assert.Empty(t, err) assert.Zero(t, err) ``` We should recommend using `NoError` ```go var err error assert.NoError(t, err)...

len: typed len check

4

This pattern is currently not detected ``` assert.True(t, uint32(len(arr)) == whatever) assert.Equal(t, whatever, uint32(len(arr))) ``` here are examples https://github.com/hrygo/gosms/blob/a86be4529f49edfd239fcb7a73a0db4c72924bae/codec_test/sgip/submit_test.go#L24 ```go assert.True(t, uint32(len(dt)) == submit.PacketLength) ``` https://github.com/foxcpp/go-imap-backend-tests/blob/958ea5829771f889ccc42c89ab0f7a74ad0d5e01/mailbox.go#L233 ```go assert.Equal(t, uint32(len(testMsg)), msg.Size,...

Here is a valid piece of code I have in my code base There is a function that returns an int32, the tests checks if the value is under the...