E-Hentai-Downloader icon indicating copy to clipboard operation
E-Hentai-Downloader copied to clipboard

Published 20 hours ago • verified publisher icon ccloli

Add support for info.json metadata file

Open dnsev-h opened this issue 5 years ago • 3 comments

Uses the format generated from these scripts: https://github.com/dnsev-h/x/blob/master/src/api/gallery-info/common-json.js https://github.com/dnsev-h/x/blob/master/src/api/gallery-info/get-from-html.js

A Windows batch script is included to generate the xScripts.js source file using Browserify. The original scripts use some ES6 features (class, let, const, for of, etc.), and in general it looks like all of the other code in this project doesn't, so a transform is applied which should convert everything to ES5.

This fixes #137.

A fork which contains this change is available at the link below. Note that it will not always be up to date with the latest changes from the master repository. https://github.com/dnsev-h/E-Hentai-Downloader

dnsev-h avatar Jul 04 '19 18:07 dnsev-h

Is this still being looked at? People have been using the info.json metadata format for many years and switching to yet another metadata format which has less support, and contains less gallery information, really isn't ideal.

It would be really amazing to have this as an optional feature in the main builds. Many folks are using various management software which reads these json files as well.

Asinin3 avatar May 11 '20 12:05 Asinin3

@ccloli It's been four years since my last comment. Is there still any hope of this? Many of us used a fork build that had these changes, but ever since EH changed some things and caused it to break back in November (due to https://github.com/ccloli/E-Hentai-Downloader/issues/259 ) so those builds were no-longer useable. As such people using LRR don't have any easy way to DL galleries with metadata thats compatible anymore

Asinin3 avatar Apr 19 '24 08:04 Asinin3

Hi @Asinin3 , I still keep my previous statement in #148 , because the script itself is 💩 (no, I mean E-Hentai Downloader itself), adding extra feature that provided by another library may out of my ability. So I still can't merge this PR into master, truly sorry for that.

For your case, I created a new branch that merges this PR in latest version. In the future, I may write a CI to merge it automatically, if I'm not too lazy. Though to be clear, I cannot maintain or response to any bugs that related to dnsev-h/x itself.

https://github.com/ccloli/E-Hentai-Downloader/tree/dnsev-h_x-info

ccloli avatar May 05 '24 08:05 ccloli