cclerget
cclerget
@lifubang Will look if I can move that into `setnsProcess.start`
@lifubang I pushed change for a go only version https://github.com/opencontainers/runc/pull/3923/commits/06e7e3ba76fdf37f83d9e9e5e15f8bebcadbf8cb, I left previous commit just in case, notable change is to set CPU affinity right before executing the runc init...
@lifubang > Could you please add an integration test to read and check cpuAffinity value in the container with some mock data in https://github.com/opencontainers/runc/blob/main/libcontainer/integration/exec_test.go? Now the question is, do you...
@lifubang the hacky way yeah, that should do it, hoping to not interfere with other tests running in parallel in the future, there is few chance but we never know
> One other observation -- you add some code to the first commit, when remove most of it in the second one. Perhaps you can rework this to avoid doing...
Hello @kolyshkin @lifubang @AkihiroSuda , any chance to get it reviewed please ?
Hello @kolyshkin @lifubang @AkihiroSuda, I marked the PR as ready for review, the code is actually well covered by various tests, the feature is disabled by default and can be...
Ok I've pushed the requested changes, I haven't applied changes related to your comments https://github.com/opencontainers/runc/pull/3923#pullrequestreview-1962335750 and https://github.com/opencontainers/runc/pull/3923#pullrequestreview-1962330692, please let me know if you disagree with my comments, otherwise I'll go...
@bnprks @d33bs @DrDaveD the underlying package used is supporting various references, so taking the original manifest from the archive : ``` $ tar xvf /tmp/bpcells_bench_0.3.tar.gz manifest.json $ [ { "Config":...
@verdurin Singularity use `/tmp` as temporary folder to build image, so your `/tmp` directory is a RAM filesystem like `tmpfs`. By default `tmpfs` use almost 50% of total memory, which...