Christian Clauss

Results 1510 comments of Christian Clauss

Nice work! So the rule going forward should be: If Travis is not green, the PR should not be merged.

You can check the last box in the list above.

Is it time to check the second last box above?

It would be good if the software would display a clear warning if the user forgets to specify a search. Or it could execute a reasonable default.

> npm ERR! gyp ERR! node-gyp -v v3.8.0 node-gyp v9 is current. https://github.com/nodejs/node-gyp/releases https://github.com/nodejs/node-gyp/tree/main/docs#readme

https://github.com/nodejs/node-gyp/blob/main/docs/Updating-npm-bundled-node-gyp.md ?

@hangzhaomit Your review please.

See https://github.com/sunpy/sunpy/blob/master/.circleci/config.yml

https://github.com/PyCQA/flake8/tree/master/docs/source/release-notes 3.7.0 [upgraded](https://github.com/PyCQA/flake8/blob/master/docs/source/release-notes/3.7.0.rst) pyfakes and pycodestyle so it is unclear to me. Opt-in upgrade sounds like the best bet. Perhaps a version number in _.hound.yml_ ``` flake8: enabled: true flake8_version:...

flake8_version: 3.7.4 --> 3.7.5 http://flake8.pycqa.org/en/latest/release-notes/index.html