Christian Clauss
Christian Clauss
Please rebase. > This branch has conflicts that must be resolved
Does this pull request do what it is intended to do? I always worry about scripts like `Tools/scripts/run_flake8.py` that walk the file system for tools that already have a built-in...
PEP8 is clear that the answer to tabs. vs spaces is [spaces](https://black.readthedocs.io/en/stable/faq.html#why-spaces-i-prefer-tabs). The best way to fix those lines is with Black, and the answer to "how have you tested...
> The key difference is that the presence of AP_FLAKE8_CLEAN is required to be in the file before we validate it the python file. Why not remove all instances of...
What is the remaining TODO on this one? It is blocking * https://github.com/ArduPilot/ardupilot/pull/30270#issuecomment-2953338341
@peterbarker wrote https://github.com/ArduPilot/ardupilot/pull/30361#issuecomment-2973677097 > Just a note that upgrading numpy won't necessarily kill in-tree tools, but most definitely kills MAVProxy, which is usually run in the same venv. This does...
Fudge! [`pysim`](https://github.com/ArduPilot/ardupilot/tree/master/Tools/autotest/pysim) != [`pysim`](https://pysim.org) https://github.com/ArduPilot/ardupilot/tree/master/Tools/autotest/pysim is not https://pysim.org
https://github.com/ArduPilot/ardupilot/pull/30361#issuecomment-2973677097 > upgrading numpy [ ... ] most definitely kills MAVProxy which is usually run in the same venv. This does suck. Modernizing Numpy usage in MAVProxy might help us...
@misl6 @matham your reviews, please.
@inyutin Your review, please.