Christian Clauss
Christian Clauss
Python 3.8 is now also end-of-life. https://devguide.python.org/versions/#unsupported-versions
I am going to split this into two separate PRs * This one will focus on `flake8` given the complexities of the extra layer of `ament-flake8`. * #30414 (merged) can...
Looks like everyone has approved... Are there remaining todos on this one?
This PR would ___not___ have `automated systems modify the content of pull requests`. I had to run the `chmod` commands manually. The proposed GitHub Action would flag violations as errors...
`git add .github/workflows/pre-commit.yml`
Why does this pull request require * #30272 ? ~This repo does not currently run `flake8` in pre-commit [but probably should](https://github.com/ArduPilot/ardupilot/pull/30272#issuecomment-2953729652).~
@amilcarlucas If you like flake8 then I encourage you to try [ruff](https://docs.astral.sh/ruff) on one of your projects. A rewrite in Rust that is lightning fast and and also replaces black,...
`ruff check - -select=PL` covers most pylint rules. There is a `ty` tool in beta from the same folks which should become a lightning fast replacement for `mypy`.
`pre-commit` failures are addressed in: * #30340
Upgrades are NOT automatic. It would require a `pre-commit autoupdate` pull request like. * #30372