cchudant

Unsound: setting a snapshot on ReadOptions can result in use-after-free

3

I've noticed that you can set a snapshot on ReadOptions, but ReadOptions does not depend on any lifetime. This is unsound as the snapshot can be dropped in the meantime:...

Feature proposal: Implement PeekingNext on std::vec::IntoIter & more

2

Current [PeekingNext](https://docs.rs/itertools/latest/itertools/trait.PeekingNext.html) trait is only implemented for std iterators that can be copied easily. This is done using the [`peeking_next_by_clone!`](https://docs.rs/itertools/latest/src/itertools/peeking_take_while.rs.html#165-201) macro in the implementation, and affects: - `::std::slice::Iter` for Vec/Slices/arrays...

## Changes This was proposed by @kkovaacs, but I added the field to getTransactionReceipt too instead of just getEvents. Related to #326 (which adds finality_status to the same types) and...

Add finality status to EmittedEvent

1

## Changes It would be cool to return the finality status when returning events in `starknet_getEvents`. In fact, I think it's really necessary, otherwise consumers of the jsonrpc API cannot...