Christopher Choquette Choo

Results 19 issues of Christopher Choquette Choo

https://github.com/georgianpartners/foreshadow/pull/111/review_comment/create convo: https://github.com/georgianpartners/foreshadow/pull/111#discussion_r310229589 reference numpy.

_Originally posted by @cchoquette in https://github.com/_render_node/MDE3OlB1bGxSZXF1ZXN0UmV2aWV3MjY5MDU3NTk3/pull_request_reviews/more_threads_ https://github.com/georgianpartners/foreshadow/pull/111#discussion_r309284008 __known issue__, if we subclass a child of PreparerSteps, this will not work. We can fix this then.

https://github.com/georgianpartners/foreshadow/pull/111 convo: https://github.com/georgianpartners/foreshadow/pull/111#discussion_r309283166 TBD until needed.

https://github.com/georgianpartners/foreshadow/pull/111 convo: https://github.com/georgianpartners/foreshadow/pull/111#discussion_r309279796 Current checks use lists/tuples, figure out why/how indices are handled.

https://github.com/georgianpartners/foreshadow/pull/111 convo: https://github.com/georgianpartners/foreshadow/pull/111#discussion_r309271801

#### Description May need to remove pipeline steps. Take a look at sklearn 0.21 for their pass-through implementation.

#### Description model.json is being created on run of pytests. Look into why and how it is being created and turn it off (if it is needed, add to the...

#### Description Migrate usage of the kwarg: "full_df" to ColumnSharer

#### Description test inverse transform for each output type