ytermusic icon indicating copy to clipboard operation
ytermusic copied to clipboard

Add repeat mechanisms

Open Alphare opened this issue 2 years ago • 6 comments

I frequently listen to new albums on repeat to get a better feel for them, and sometimes individual songs that I really enjoy. Having a way of setting "repeat album" and "repeat song" would be very nice.

The issue I can see with "repeat album" would be that it could confuse the user intent of whether they're asking to replay the whole media player history (if other things were played before), or just the current album/playlist. Not sure if you simply want a third repeat mode. :)

What do you think?

Alphare avatar Jan 05 '23 10:01 Alphare

What I can do:

  • Add a shortcut to clean the history and maybe one to only keep the current song (equivalent for loop this title mode)
  • Place the history in the queue when the queue is empty (loops all musics in history)
  • So no need for a special repeat mechanism

ccgauche avatar Jan 05 '23 20:01 ccgauche

I feel like this is more context-dependent and less obvious from a UX perspective than having repeat modes.

With repeat mode you can have:

  • a shortcut for each repeat mode without having to think about your history
  • the easy ability to undo what you just did
  • a clear icon that shows the repeat state (None/Playlist/Album/Track)
  • a simple configurable default behavior

Honestly it's also how basically all music players do it, so it's not really taking much risk. :)

Alphare avatar Jan 06 '23 09:01 Alphare

a clear icon that shows the repeat state (None/Playlist/Album/Track)

what icon are you thinking of?

maybe something like these? ↺ ⟲

Rustmilian avatar Feb 19 '24 05:02 Rustmilian

I think I'm just going to add a loop icon before the song title on the seeking bar. Or on the playlist title. With a shortcut like L to switch between looping modes

ccgauche avatar Feb 19 '24 13:02 ccgauche

I think I'm just going to add a loop icon before the song title on the seeking bar. Or on the playlist title. With a shortcut like L to switch between looping modes

That's actually the same thing I was thinking of too when I started brainstorming solutions for this yesterday, tho I'd put the icon after instead of before.
I think this solution is the best, most strait forward & simplest solution; which is perfect for this.

I'm still a little concerned about which loop icon you'll go with. I recommend going with a plain Unicode one and not an emoji to make sure it works well on all terminals.

Rustmilian avatar Feb 20 '24 00:02 Rustmilian

I have lots of improvements to make before starting to add new features (aka Improve the underlying api to make it faster, simpler and more resistant to changes on youtube data structures (which happens quite often).

ccgauche avatar Feb 20 '24 08:02 ccgauche