Sink icon indicating copy to clipboard operation
Sink copied to clipboard

URLs with length greater than around 1000 characters fail

Open cornhusk-web opened this issue 9 months ago • 6 comments

I'm aware of the 2048 character limit and the ability to modify this on my own fork (https://github.com/ccbikai/Sink/issues/8)

I've tried to modify that limit on my fork because I want to shorten URLs with length greater than 2048. But actually I'm having issues with URLs of anything greater than around 1000 characters.

Of the examples below, #1 (1012 characters) works, but #2 (1016 characters) just does nothing. I click 'save' on the create link popup and nothing happens. Also with an API request, the request just hangs. So same behaviour on the webpage and with the API.

Is there a way to get links with length greater than approximately 1012 characters to work?

Thanks.

URL #1:

https://www.google.com/search?q=testtesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttest

URL #2:

https://www.google.com/search?q=testtesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttest

cornhusk-web avatar Mar 05 '25 13:03 cornhusk-web

Error: KV PUT failed: 413 Metadata length of 1026 exceeds limit of 1024.

https://developers.cloudflare.com/kv/api/write-key-value-pairs/#put-method

metadata is an object that must serialize to JSON. The maximum size of the serialized JSON representation of the metadata object is 1024 bytes.

I found the reason is that the metadata information is too long, let me think about how to optimize it

miantiao-me avatar Mar 16 '25 05:03 miantiao-me

Storing URLs in metadata is to reduce the number of KV reads during search

miantiao-me avatar Mar 16 '25 05:03 miantiao-me

Hey,

Thanks for explaining! If you are able to optimise it to allow metadata (and therefore URLs) longer than 1024 characters that would be really great!

Thanks.

cornhusk-web avatar Apr 03 '25 12:04 cornhusk-web

I don't really think URLs that long are necessary. It could be fine to just handle with an error at creation. What's your usecase @cornhusk-web?

7heMech avatar Apr 28 '25 10:04 7heMech

I don't really think URLs that long are necessary. It could be fine to just handle with an error at creation. What's your usecase @cornhusk-web?

Unfortunately for me the ability to shorten longer URLs is vital — my use case is search queries on e-commerce sites where there are a large number of search terms / filters included in the URL.

cornhusk-web avatar Apr 29 '25 08:04 cornhusk-web

Hi @ccbikai is there any possibility of this being fixed, so that URLs with a length of over 1000 characters? Just checking because I need to migrate from Firebase Dynamic Links before the deprecation date of 25th of August and I'd like to understand if Sink will be a migration option. Thanks!

cornhusk-web avatar Jul 02 '25 14:07 cornhusk-web