jgnash icon indicating copy to clipboard operation
jgnash copied to clipboard

Move main class to new package: jgnash.app

Open msgilligan opened this issue 6 years ago • 4 comments

This will help when/if we add support for JPMS.

msgilligan avatar Aug 30 '19 06:08 msgilligan

Some of the weirdness for keeping jGnash where it's at was integration into Linux and macOS desktops and the displayed application name. This was due to Java limitations at the time. I'm currently unable to test for proper behavior on macOS.

ccavanaugh avatar Aug 31 '19 09:08 ccavanaugh

Some of the weirdness for keeping jGnash where it's at was integration into Linux and macOS desktops and the displayed application name.

Is there something preventing us from moving jGnashFx into a package like jgnash.app?

I'm currently unable to test for proper behavior on macOS.

I'm a macOS user and it's also my main development platform, so (if I decide to stick with my current plans) I should be able to help with this a little.

msgilligan avatar Sep 01 '19 01:09 msgilligan

I've been able to perform a bit of testing with OSX using a VM. It's not 100% The biggest annoyance is the java menu with jgnash.app.jGnashFx being displayed. It doesn't impair function, so I'm okay as is.

Screenshot from 2020-02-10 19-07-57

http://bekwam.blogspot.com/2015/11/mac-menus-in-javafx-app.html provides a potential workaround. I think a variation that targets OSX only is workable until JavaFX improves integration.

ccavanaugh avatar Feb 11 '20 00:02 ccavanaugh

The biggest annoyance is the java menu with jgnash.app.jGnashFx being displayed.

Take a look at NSMenuFX -- I've used it successfully in the past and it is being updated for newer Java lately (there's a 2.1.7 release that isn't listed on the site)

msgilligan avatar Feb 13 '20 17:02 msgilligan