chromephp
chromephp copied to clipboard
ccampbell
Global enable / disable, very basic FirePHP compatibility
Implemented a global enable / disable function and a setting to switch on or off FirePHP compatibility (defaults to off). If switched on argument order is changed if exactly 2 arguments are passed to the various log functions to be able to re-use old FirePHP calls.
Coming from FirePHP myself this is generally a good idea, but you changed a bit more than necessary, which I think is inappropriate. Maybe just add the switch and leave the rest up to the maintainer?
Well, I changed exactly what was needed to make it work for me. Said that I'd like to know what exactly you think is more than necessary.
Hi @Erik-Krause / ( @erikkrause ?) thanks you very much for your adds !
Maybe you can change your composer.json to set the name as erikkrause/composerphp and register it in composer ?
Whenever you fork a project via GitHub and you maintain its master branch way after you make a PR on the original PR, this is what happens. That's why I literally deleted my fork and just created a standalone repo.
@Erik-Krause Can you prepare a PR for phpexpertsinc/chromephp#3? I don't want the composer.json changes. I don't want all those (ek) comments, but your copyright clause comments are very good and well, especially since the Apache v2 license pretty much requires attribution.
What do you mean by "all those (ek) comments". I won't remove the FirePHP compatibility changes, since that's the whole point. Apart of that I like your proposal to move this to a new repo.