chromephp icon indicating copy to clipboard operation
chromephp copied to clipboard

use PHP_VERSION and version_compare() where appropriate

Open okonomiyaki3000 opened this issue 11 years ago • 3 comments

We don't need to store $_php_version because there is already PHP_VERSION. version_compare() is the correct way to compare or test version numbers.

Also, I didn't remove it here, but $_timestamp seems to be unused. Do we actually need this value for any reason?

okonomiyaki3000 avatar Apr 01 '14 08:04 okonomiyaki3000

Thanks @DanMan

This is a great library but has it been abandoned?

okonomiyaki3000 avatar Feb 03 '17 00:02 okonomiyaki3000

YW @okonomiyaki3000 . Judging from the commit history, yes. Maybe you can put your fork on packagist.org ? I think it might be the most complete.

It's a shame that this isn't a drop-in replacement for FirePHP. At least the enable/disable switch would be very useful. I've currently wrapped this one in another shallow class of my own to accomplish that.

DanMan avatar Feb 03 '17 10:02 DanMan

@okonomiyaki3000 I merged this PR into my own fork of chromephp so that your work wouldn't be completely in vain. But honestly? comparing PHP 5.3 and 5.1? Damn, this code has rotted!

I scarcely even remember the days when ReflectionMethod::setAccessible() didn't even exist (pre-5.3.2!).

hopeseekr avatar May 15 '19 02:05 hopeseekr