Cristian Cadar

Results 198 comments of Cristian Cadar

@251 LSan does report leaks in those tests, and it would be nice to address those reports.

You are right, this particular test has a comment disabling ASan and explaining the issue, so let's close this PR (but we can continue the discussion if needed). On the...

I'm not against using the functionality for enforcing timeouts in STP or Z3, but I think we need some experimentation before making that the default.

Thanks, I will comment on this PR soon.

@qrort Thanks for this contribution! It would be of course great to have this in the mainline, but we need to integrate it more incrementally. Would you be interested in...

@qrort Thanks for the update. Both email and GitHub communication is fine with me. I saw this useful PR opened for a while now, and I wanted to see what...

I think we should add this, as it's not an exotic option -- this XML-formatted tests are now supported by many other tools. There are also a number of KLEE-based...

@MartinNowack You will also need to fix compilation for LLVM < 4: ``` /tmp/klee_src/tools/klee/main.cpp:573:21: error: 'APFloatBase' was not declared in this scope llvm::APFloat(APFloatBase::IEEEdouble(), v).print(*file); ^ ```

LGTM, but it would be nice to have a test case in `test/Intrinsics` (or enhance an existing one in that directory)

Thanks, @operasfantom . I agree, we haven't done a good job requesting tests for various intrinsics, but it would be useful to have at least one test covering each of...