Cristian Cadar

Results 198 comments of Cristian Cadar

@jbuening nice find. Is this the mapping that KDAlloc creates, or MSan?

@danielschemmel @jbuening great! As we discussed live, it would be useful to have a run where KDAlloc is enabled by default and understand any test failures.

Thanks, @danielschemmel. We can remove that commit for now. I see KDAlloc is implemented via a single giant commit. Is there an opportunity to split it a bit, to make...

Thanks, @danielschemmel. @jbuening @251 @MartinNowack can you have a first look?

@danielschemmel Thanks for these tests, we should merge them. But I would merge the tests using the same C file into a single one, in which you run all commands.

@MartinNowack @251 I'm a bit confused as to why these tests pass on the ASan CI runs. They fail on my machine.

To clarify: I haven't tried the CI scripts, but rather I see these errors being reported when I compile with `-fsanitize=address` or `-fsanitize=leak`.

OK, I haven't realised we have those ignore files...

Thanks, @hovhannes-96, this LGTM. Does this resolve all the issues you mentioned in #1512 ? Also, the patch was not formatted via clang-format.

@251 can you articulate what changes you'd like to see here?