python-poppler icon indicating copy to clipboard operation
python-poppler copied to clipboard

adding some type hints and few type checks

Open farooqkz opened this issue 3 years ago • 5 comments

Hello there. I have added some Python type hints and a few type checks. Please let me know if I should change anything. Regards, Farooq.

farooqkz avatar Apr 14 '22 15:04 farooqkz

So you are asking me to add type hints to all files?

farooqkz avatar Apr 21 '22 13:04 farooqkz

So you are asking me to add type hints to all files?

yes, if it is something you'd like to do, it would be a great contribution. I would not add any explicit type checks however.

cbrunet avatar Apr 21 '22 23:04 cbrunet

So you are asking me to add type hints to all files?

yes, if it is something you'd like to do, it would be a great contribution. I would not add any explicit type checks however.

Currently, I don't have time to do the type hints for all of the API. And I suppose having type hints for some parts is better than not having them at all.

farooqkz avatar Apr 23 '22 06:04 farooqkz

@cbrunet any other change required?

EDIT: Sorry I forgot it for a long time...

farooqkz avatar Dec 03 '22 16:12 farooqkz

@cbrunet enough sleep! wake up!

farooqkz avatar Dec 13 '22 06:12 farooqkz