Clemens Brunner

Results 820 comments of Clemens Brunner

Note that we could also force specific NumPy versions for each Python version as shown e.g. [here](https://github.com/the-siesta-group/edfio/blob/main/.github/workflows/test.yml) (they are testing the oldest supported NumPy version for each Python release). The...

> However, I don't think wfdb package should _require_ numpy 2 at this stage, and I'm not inclined to change that just to appease uv. Of course, that's why I...

If you are completely unhappy with uv, I can also get rid of it again and replace it with pip, just let me know.

OK, I'd really appreciate if someone took a look. I've now enabled `weak_and_warn`, and the Python 3.9 job on Ubuntu uses `numpy==1.26.4` (all other jobs use `numpy>=2`). One test fails,...

Since uv has a new solver which now by default behaves like pip (https://github.com/astral-sh/uv/pull/9868), I'll revert to using `uv sync` and `uv run` again (will take a little time though)....

Alright, this seems to be working now. @bemoody @tompollard it would be great if you could take a look and merge if you're happy with the changes. A quick follow-up...

One approach would be to allow passing a 2D array (shape N × 2, each row contains a pair of start/stop times) to `times`. Or maybe a list of 2-tuples....

Yes, this is certainly a big improvement over the current status! 👍

I cannot reproduce it either, I just tried on Linux. Let me try if this was specific to macOS later today, otherwise I'll close this issue.

I still get the error by running `test_read_shhs()`; I forgot that I silenced this `DeprecationWarning` in `pyproject.toml`, so that's why I didn't see it yesterday.