Chris Bracken

Results 112 comments of Chris Bracken

Or even just a "test" that always passes but collects ~10 frame intervals and logs min, average, max?

Yep, as mentioned on Discord, I think we should re-land this. I don't trust our benchmarking on this one at all and looking into it is hugely time-consuming given the...

Converting to draft PR to keep it from coming up in triage.

@matanlurey this is pretty old should this be closed or are you planning on working on it? (Desktop triage)

Unassigning since this is one of the web-tests and the issue seems to be related to flutter driver, which which I'm not familiar. Looking at the PR I suspect I...

Looking quickly at the output and code, it looks like: 1. We synchronously delete `build/integration_response_data.json` 2. We run whatever web test this is 3. We synchronously check for the presence...

Related context: * https://groups.google.com/d/msg/bazel-discuss/SnXvMgAUGzI/WAN7R0S2BwAJ * https://github.com/bazelbuild/bazel/issues/10207 * flutter/flutter#19680 * flutter/flutter#14125

Hi Joackim, There's an old `dart_proto_library` branch that adds a rule. It's probably fairly out-of-date at this point. [This is the commit](https://github.com/cbracken/rules_dart/commit/9b127ad3878a505d27c7c242a4c99df62cddb3f3) where I landed it at the time. The...

What I believe is going on is that Visual Studio error messages are not necessarily unicode, but rather encoded in a region-specific codepage. Somewhere in our code we're making the...