Chris Bracken
Chris Bracken
Yep - I was looking at doing just that; the one issue with NSPointerArray is that it doesn't have a remove by value message, just by index. Probably still worth...
It appears we're blowing the 30 second timeout on a flutter_driver check in https://ci.chromium.org/ui/p/flutter/builders/prod/Mac%20platform_channel_sample_test_macos/7735/overview Specifically: ``` [2024-07-15 22:12:16.528785] [STDOUT] stderr: [ +11 ms] VMServiceFlutterDriver: Isolate found with number: 6725079622540015 [2024-07-15...
We believe these timeouts are due to a general issue with the recent (June 2024-ish) macOS 14 bot image update. For now, due to prioritisation decisions, as these flakes arise,...
Well well well. Here's a hint as to what's up. The debug build isn't very debug. :) ```diff % diff -ub out/ios_debug_sim_unopt_arm64/args.gn out/ci/ios_debug_unopt_sim_arm64/args.gn --- out/ios_debug_sim_unopt_arm64/args.gn 2024-10-29 11:33:09 +++ out/ci/ios_debug_unopt_sim_arm64/args.gn 2024-10-28...
My intent is to land this the same way as I did for macOS and iOS: the existing binaries will be replaced by universal binaries. I haven't evaluated the difficulty...
> [@cbracken](https://github.com/cbracken) breadcrumb for an issue that may also come up for Android: [#156175](https://github.com/flutter/flutter/issues/156175) Good thing you commented, because thinking about my patch, it 100% will.
Consider `dartcov` as per @seaneagan's suggestion.
This is queued up behind https://github.com/flutter/engine/pull/55669, which should land today.
Alright this is ready for review whenever people are ready to give it a look. We're finally at the end (compile/linker-wise), folks!
Yep! @matanlurey picked up [my other one](https://github.com/flutter/engine/pull/52241), which I've now closed. Once his patches land, I'll rebase this and land it.