Chris Bracken

Results 112 comments of Chris Bracken

Yeah; this is an easy fix but testing it requires me to land fixture test support for linux, which shouldn't be too hard to do. I'll see if I can...

/cc @robert-ancell for thoughts. @jane400 is this still something you're looking into? If so, unfortunately policy requires a signed CLA from contributors as mentioned in the bot reply above. Info...

@ardera is this still work in progress?

@ardera this appears to be failing tests due to what appears to be memory leak (possibly among other things). Once this gets to the state where all tests are passing,...

I'll see if I can override the CLA bot, but: (a) I'm a Google employee and therefore don't need one. (b) The email address I use for commits is registered...

CLA bot is now happy. I have made some changes to the underlying domain -- same one but no longer associated with a Gaia (google) account of that name, so...

@ajhemphill91 Looks like Dart formatting and CHANGELOG format checks are failing. See the log here for details: https://ci.chromium.org/ui/p/flutter/builders/try/Linux%20repo_checks/4671/overview Once those are done, I leave it up to you as to...

If it's useful, it looks like some work has been done on this fork: https://github.com/cbracken/rules_dart/compare/master...malkia:master I'm not sure whether it works at all, and I believe it's probably pretty out-of-date,...

It's been a _while_ since I took a look at layout_action, but my recollection is that this was required because with Bazel, there are three places a tool might go...

Re: replacing it with something more Starlarky: I wonder if this has been solved by changes to Starlark in the years since that bit was hacked together. I also suspect...