Chris Bracken

Results 112 comments of Chris Bracken

Based on the platform-specific behaviour, it looks like a bug to me. Both Android and iOS appear to use the line height. It seems potentially useful to expose the glyph-specific...

This doesn't appear to be fixed. /cc @GaryQian I'm guessing that we're mixing a framework PR to take advantage of the new API that was added in #6644.

Since this is resolved on Windows, I've added a set of platform checkboxes in the description and am removing the windows label.

@yaakovschectman has added infrastructure for testing template code. The tests for this code are in https://github.com/flutter/flutter/pull/118647. Apologies for the delay on getting infra in place on our end. Do you...

This may be a duplicate of https://github.com/flutter/website/issues/9246. Fixes for those instructions will land in: https://github.com/flutter/website/pull/9282

/cc @brianquinlan in case he can think of any workarounds for https://github.com/dart-lang/sdk/issues/50904 (desktop triage)

Added a teensy cleanup to make the linter happy (and rebased).

I've marked this as ready for review since the underlying blocker is now resolved. @mtolmacs can take one last pass to be sure he's good to go and reply re...

@mtolmacs you can build against the non-prebuilt Dart SDK by passing the `--no-prebuilt-dart-sdk` option to `flutter\tools\gn`. Sorry about the confusion. @zanderso how frequently does the prebuilt Dart SDK roll in...

The engine tests are (mostly) centrally-managed in [run_tests.py](https://github.com/flutter/engine/blob/main/testing/run_tests.py) which is wired into CI in the build config files such as [this one](https://github.com/flutter/engine/blob/48e0b4e664222e81b5ace29623db8811ed19e7b3/ci/builders/mac_host_engine.json#L48-L62). I think we're probably fine to land this...