fsearch icon indicating copy to clipboard operation
fsearch copied to clipboard

[BUG] Can't remember the position

Open tonypachino opened this issue 3 years ago • 13 comments

Describe the bug

  1. Can you make that when i double click between let's say name and path i get that stretch of the full name or full path automatically just by double click?

  2. Can you make the option in Preferences that Fsearch remember that stretched position?

  3. I'm using KDE Plasma, can you make a feature to minimize it only in system tray, so that i can only see a system tray icon and not in taskbar when it's open and that i can call the window with choosen key, for example with F3 ?

To Reproduce Steps to reproduce the behavior:

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

Expected behavior A clear and concise description of what you expected to happen.

Screenshots If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

  • OS: [e.g. Ubuntu 20.04]
  • How you installed FSearch [e.g. built manually, PPA, AUR]
  • Version [output of fsearch --version]
  • Output of localectl status

Additional context Add any other context about the problem here.

tonypachino avatar Sep 13 '21 17:09 tonypachino

Can you make that when i double click between let's say name and path i get that stretch of the full name or full path automatically just by double click?

It's certainly possible, but I need to do some performance testing first. The problem is that this feature needs to calculate the rendered text length of all rows, which might be an issue when there are millions of them.

However if it is too slow, I could at least make it that it only considers the text of the currently visible rows.

Can you make the option in Preferences that Fsearch remember that stretched position?

Yes.

I'm using KDE Plasma, can you make a feature to minimize it only in system tray, so that i can only see a system tray icon and not in taskbar when it's open and that i can call the window with choosen key, for example with F3 ?

Yes, it's on my todo list. See #52

cboxdoerfer avatar Sep 13 '21 18:09 cboxdoerfer

or you can make it to do it automatically, to stretch it to the most longest search result?

tonypachino avatar Sep 13 '21 18:09 tonypachino

If Fsearch is running will he update a database when some files are changed in system or it only can do it every let's say few min?

tonypachino avatar Sep 13 '21 18:09 tonypachino

I forgot to tell you: can you remove the space between the Name, Path and others and that there is only a vertical line like in other apps, i think it should look better, only my opinion.

tonypachino avatar Sep 13 '21 18:09 tonypachino

or you can make it to do it automatically, to stretch it to the most longest search result?

This doesn't work reliably, especially with some non-latin characters this might be really inaccurate. The issue is that a longer string doesn't necessarily translate to a longer rendered text. An extreme example is the U+200B character, which has a string length of one but when you render it it'll have zero width.

If Fsearch is running will he update a database when some files are changed in system or it only can do it every let's say few min?

No, monitoring for file changes is not supported yet. It's tricky to implement on Linux, but it's on my todo.

I forgot to tell you: can you remove the space between the Name, Path and others and that there is only a vertical line like in other apps, i think it should look better, only my opinion.

Can you post a screenshot, maybe with highlighting the space you mean?

cboxdoerfer avatar Sep 13 '21 18:09 cboxdoerfer

pic Here, you can only leave a vertical line between name and path

tonypachino avatar Sep 13 '21 18:09 tonypachino

Ah I see, that's a theming issue. Which GTK theme do you use? With Adwaita on my PC it looks like this, which is how it's supposed to look like: 2021-09-13_20-55

cboxdoerfer avatar Sep 13 '21 18:09 cboxdoerfer

I'm using Breeze Dark with Application Style: Fusion, Windows Decorations: Matcha-sea

tonypachino avatar Sep 13 '21 19:09 tonypachino

Thx, I'll see if there's anything I can do on my part to fix that, without breaking it for other themes.

cboxdoerfer avatar Sep 13 '21 19:09 cboxdoerfer

Added some tweaks to the application stylesheet, it looks fine now on my PC. Please let me know of it works for you as well.

cboxdoerfer avatar Sep 13 '21 19:09 cboxdoerfer

now looks perfect!

Thank you!

tonypachino avatar Sep 13 '21 19:09 tonypachino

As far as I can tell, everything doable here was done, this ticket should then be closed?

nekohayo avatar Dec 03 '22 14:12 nekohayo

Looking at this again:

  • Window sizes are remembered now.
  • Window positions can't be restored under Wayland
  • The whole "tray icon" / "run in the background" idea is a duplicate of #327, #487, #52.

As such, I would recommend closing this ticket.

nekohayo avatar Jan 20 '24 15:01 nekohayo