Chadwick Boulay comments

Results 382 comments of


                                            Chadwick Boulay

Add support for Blackrock NSx files with per-sample PTP nanosecond timestamps

OK I've rebased and fixed the conflicts along the way. Let's hope the tests pass. BTW, I don't mind if you squash the commits when merging... there was some back...

Add support for Blackrock NSx files with per-sample PTP nanosecond timestamps

Actually I went ahead and squashed into 1 commit. The unit test isn't running because it can't find the file. I guess I'm not providing its path correctly. Can anyone...

Add support for Blackrock NSx files with per-sample PTP nanosecond timestamps

I'm pretty lost trying to figure out what's going on the with file loading. I'm happy to yield to someone else.

Add support for Blackrock NSx files with per-sample PTP nanosecond timestamps

I don't see the option to allow edits from maintainers. I found the [GH docs](https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/allowing-changes-to-a-pull-request-branch-created-from-a-fork) that explains it but the option isn't on this page.

Add support for Blackrock NSx files with per-sample PTP nanosecond timestamps

Ah, it's because I made the PR from the lab org. [sigh](https://github.com/orgs/community/discussions/5634)

Add support for Blackrock NSx files with per-sample PTP nanosecond timestamps

I tried copying the pattern of the other files (blackrock_2_1, blackrock_3_0). It works locally but not on the runner. Your suggested changes break from that pattern and don't work locally...

Add support for Blackrock NSx files with per-sample PTP nanosecond timestamps

Seems to be working. Thanks for your help!

Minor misuse of timing info in Blackrock headers

Hey, sorry for being absent on this. Yes, I'm fairly certain this is solved with #1338

LabRecorder crashed while closing the file; saved XDF cannot be read by load_xdf

Here is where LabRecorder writes the footer: https://github.com/labstreaminglayer/App-LabRecorder/blob/becc09e8bf2ff7b83c6b161a55469fa0a898d879/src/recording.cpp#L258-L270 You can see that it's writing `offset_lists_`, which are important for synchronizing streams from different originating PCs. However, LabRecorder also has a...

Expose time_func to stream() and allow option to use pylsl timestamps

@alexandrebarachant , I'm sure Dominique didn't want to change the way things work so they opted to keep time.time() as the default, but the default way is incorrect and IMO...