nexus icon indicating copy to clipboard operation
nexus copied to clipboard

Published 20 hours ago • verified publisher icon cbodley

bug fix

Open amdfxlucas opened this issue 1 year ago • 4 comments

  • connection_state::open::incoming_streams was uninitialized ( connection erroneously couldnt accept streams because circular buffer wrongly deemed full (capacity zero) )

  • reading from stream never returned EOF after peer shutdown its end for write

amdfxlucas avatar Nov 20 '23 11:11 amdfxlucas

Indeed, the client did not respond in any way after being notified of the server disconnection, which can be resolved by applying this fix.

nmgwddj avatar Nov 22 '23 07:11 nmgwddj

thanks @amdfxlucas @nmgwddj. i haven't been working on this library, but i'm happy to merge under the conditions that you:

  • update the changes to be consistent with the existing coding style (indentation, spacing, braces)
  • add a test case that exercises this bug/fix

cbodley avatar Nov 22 '23 14:11 cbodley

i'm happy to review additional changes, but please open a separate pull request for each feature, with commit messages that describe the changes and their motivation

cbodley avatar Nov 23 '23 17:11 cbodley

oops, pushed to wrong branch. Didnt want those commits to show up here

amdfxlucas avatar Nov 24 '23 11:11 amdfxlucas