Casey Bodley

Results 125 comments of Casey Bodley

@AndrewJDR @outscale-mgo kindly requesting your thoughts on the comment above

hi @outscale-mgo, thanks for taking a look! > Maybe there is other way, like checking if x-amz-content-sha256 is present but doesn't contain a sha256 nor s3's special values then we...

to summarize the proposed algorithm: 1. check for x-amz-content-sha256 header 2. if service=s3 and no header existed, add x-amz-content-sha256: UNSIGNED-PAYLOAD 3. for CanonicalRequest, use value from header or calculate the...

> By generating "real payload hash", I mean use what we've already have, like you've done in your PR, and push the header when requested by user. got it, thanks...

> And worst than that, if someday amazon change the algorithm require for s3, all curl version having hardcoded `s3` detection in they parameter will fail. such API changes would...

thanks @outscale-mgo @bagder, > At the end, the signature V4 is just a signature protocol, and could be implement by any Service providers. so curl code should be usable by...

> 1. check for x-amz-content-sha256 header > 2. if service=s3 and no header existed, add x-amz-content-sha256: UNSIGNED-PAYLOAD > 3. for CanonicalRequest, use value from header or calculate the hash from...

> For the point 2: once we have decide on the condition to enable it, it seems to me it would be more useful for the user, if we add...

> I think there is 2 different approach to having a V4 generic: > - 1rst one is to follow this https://docs.aws.amazon.com/general/latest/gr/sigv4-create-canonical-request.html by default, and have an option for every...

discussed this a bit with @alimaredia. if there's a need to expose zone endpoints, i'd recommend pointing zone endpoints at the object store's load balancer and exposing that instead then...