Casey Bodley
Casey Bodley
@alimaredia's results are showing some known failures on rhel, so i rescheduled without any rhel jobs using this suite-branch: https://github.com/cbodley/ceph/commits/wip-qa-rgw-s3tests-s3select @galsalomon66 that suite-branch contains your change to `qa/rgw/s3tests-branch.yaml`, so you...
> https://pulpito.ceph.com/cbodley-2022-10-18_14:19:50-rgw-s3select_next_version-distro-default-smithi/ looks like a pass to me! @galsalomon66 can you please remove the yaml part and squash the rest of the commits?
just needs squashing down to a single commit
> please include 's3select submodule' in your commit message, if this change is intentional.
i believe the 'ceph API tests' failures have been resolved on main, but you'll need to rebase to pass
> i believe the 'ceph API tests' failures have been resolved on main, but you'll need to rebase to pass oof, i guess i was wrong. it looks like https://tracker.ceph.com/issues/57834...
will follow up with test cases if the approach looks good
@bagder thanks for the review! > Is this really a method a user would like to use? It seems a rather complicated way to get the checksum set for the...
test cases planned: - signature without X-Xxx-Content-Sha256 matches signature with X-Xxx-Content-Sha256:e3b0c44298fc1c149afbf4c8996fb92427ae41e4649b934ca495991b7852b855 (hash of empty buffer) - signature without X-Xxx-Content-Sha256 does not match signature with other values of X-Xxx-Content-Sha256 - leading/trailing...
apologies, i duplicated some of this work in https://github.com/curl/curl/pull/9588 before i saw this one > There's also the idea of supporting the X-Amz-Content-Sha256: UNSIGNED-PAYLOAD capability, which I didn't attempt in...