cboard icon indicating copy to clipboard operation
cboard copied to clipboard

Reset message state for Login and ResetPassword dialogs

Open zkarmi opened this issue 6 months ago • 2 comments

close #1847
Where error messages for the Login dialog rendered in WelcomeScreen would persist after closing and re-opening the dialog. This is addressed by replicating the componentDidMount implementation already present in SignUp.component.js: https://github.com/cboard-org/cboard/blob/2824ecf9f7749a5fe55a5af39dce66b2675663ac/src/components/Account/SignUp/SignUp.component.js#L40-L44

zkarmi avatar Jun 19 '25 16:06 zkarmi

Hi @zkarmi! Thanks – this looks great. I've assigned @gonojuarez as the reviewer, so please wait for his feedback.

Just a quick note: for each PR, we usually reference the related issue using special keywords like closes, fixes, or resolves. The most commonly used one is closes, which will automatically close the issue when the PR is merged.

I gonna modify the description :)

RodriSanchez1 avatar Jun 20 '25 15:06 RodriSanchez1

Hi @zkarmi,

I'm currently migrating the following components from class-based to functional (object-based) components:

  1. Login.component.js
  2. ResetPassword.component.js
  3. SignIn.component.js
  4. SignUp.component.js

Issue #1941

I saw your comment, and it might help me with an issue I'm facing in Login.component.js.

I’ll implement these changes in my Pull Request and will ask for your review. Thanks for helping us!

gonojuarez avatar Jun 20 '25 16:06 gonojuarez

@zkarmi we are gonna implement this changes on the Gonza PRs. After that this PR will be closed

RodriSanchez1 avatar Jun 20 '25 19:06 RodriSanchez1

Sounds good @gonojuarez @RodriSanchez1!

zkarmi avatar Jun 20 '25 19:06 zkarmi

This was solved on #1948 and #1951

RodriSanchez1 avatar Jul 01 '25 22:07 RodriSanchez1