cboard icon indicating copy to clipboard operation
cboard copied to clipboard

Fixing Issue: 1086 - Image editor

Open arjunanand23 opened this issue 2 years ago • 3 comments

This PR fixes the issue where the image editing toolbar is below the picture, which necessitates use of scrollbar for smaller monitors.

arjunanand23 avatar Apr 21 '23 23:04 arjunanand23

Thanks @arjunanand23 ! Great job @RodriSanchez1 Could you please give a review?

martinbedouret avatar Apr 26 '23 15:04 martinbedouret

hi @arjunanand23 ! Sorry for the late response. Good job! I think we can also redefine the height on setImageSize() like :

line 37
---------------------------------------------
 const setImageSize = () => {
      if (window.innerWidth < 576) {
        return { width: 248, height: 182 };
      } else {
        return { width: 492, height: 300 };
      }
    };

To avoid unnecesary scroll on the DialogContent component. Let me know what you think!

RodriSanchez1 avatar May 04 '23 15:05 RodriSanchez1

close #1086

RodriSanchez1 avatar May 04 '23 15:05 RodriSanchez1