Casper Jeukendrup

Results 673 comments of Casper Jeukendrup

But that is `setupUi` for `TestDialog`, not `EditStyle`... the correct one should be in `ui_editstyle.h`.

Thanks for testing. So the conclusion is that the whole `setupUi` function is a bit slow, but it's not caused by one specific function. Maybe it has something to do...

@ecstrema Interesting thought. You can try disabling it by going to `UiTheme::setupWidgetTheme()` and comment the line `QApplication::setStyle(this);`.

@re1san When importing a file, the resulting score will also be treated as newly created, but in that case the filename should be based on the name of the imported...

Increasing the priority, since the main issue here is that the minimum window size is too big, which is indeed very annoying, and that is probably also why those tiling...

Wow. That looks like a MSVC quirk again! `this` is not even meaningful in that context. Anyway, maybe this works? ```diff - QObject::connect(qmlEngine, &QQmlEngine::warnings, [](const QList& warnings) { + QObject::connect(qmlEngine,...

Probably you're right. But QObject::connect is surely static here, but there is one overload that is non-static. That probably confuses MSVC. We have seen that before, that time with `disconnect`...

@Jojo-Schmitz In https://developercommunity.visualstudio.com/t/bogus-warning-c4573-for-static-method-with-same-na/312074, they claim that this MSVC bug should have been fixed. But apparently not for us... Can we perhaps just disable the warning, at least for that file...

MSVC complains that we're making those structs/members bigger than their intrinsic size by specifying alignment. But in this case, that is exactly what we want to do; we want them...

Seems related to my work on the tests; that test seems to fail sometimes, and sometimes not...