Cliff L. Biffle

Results 100 comments of Cliff L. Biffle

Agreed, a compiler fence seems like the right tool. I'll send a PR when I have some time. Thanks!

From the commit history it looks like this might be a known bug; might be worth adding something to the README that the packaged versions require this workaround, lest it...

FWIW, I'm not at _all_ sure that I hooked the gamma correction at the right points in the code --- definitely open to guidance if you'd like it moved!

It's also worth calling out that gamma correction makes all mid-range brightnesses look dimmer (by design!). So it might be good to increase the default brightness multiplier (currently 51 on...

Well, would "getting the string back out for use with `TypedHeader` in `axum_extra`" be a compelling use case? If so I can send a PR.

Yeah, the renaming makes sense to me as well -- it's merely inconvenient if you're trying for portability. I've got the GPIO renamed to the point where `peripherals/gpio/v3` will apply,...

@Dirbaio > @cbiffle FYI the `stm32-metapac` PAC already supports stm32c0 chips (used in the `embassy-stm32` HAL). Oh, interesting, you appear to be using the "check in the darn register definitions...

(Noticed your suggestion to run clang-format on PRs, updated the commit accordingly -- it's done something odd to the TCMD case block, but now it's consistent.)

My read of that coverage report is that the low coverage in this patch is not a _regression,_ which is to say, the code was not tested before, and continues...

Hello! Anything else you'd like to see on this? I'd love to be able to switch back away from my fork of Polybar on Framework machines.